Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few BactoTraits columns that are missing #252

Open
realmarcin opened this issue Sep 19, 2024 · 2 comments
Open

A few BactoTraits columns that are missing #252

realmarcin opened this issue Sep 19, 2024 · 2 comments

Comments

@realmarcin
Copy link
Contributor

These were omitted earlier for sake of time -- but they do provide new features which are sizes of the ranges. I am modeling these in the ontology and will have these column names as xrefs. If its not much work, it would be good to ingest this for completness.

pHd_<=1 pHd_1_2 pHd_2_3 pHd_3_4 pHd_4_5 pHd_5_9

Nad_<=1 Nad_1_3 Nad_3_8 Nad_>8

Td_1_5 Td_5_10 Td_10_20 Td_20_30 Td_>30

Definitions are here:
https://www.sciencedirect.com/science/article/pii/S1470160X21007123

pH_delta Extend of pH units that a strain can grow (calculated from pH_Range trait: max–min value) pH unit Quantitative, categorial 6 categories (<1, ≥1-2, ≥2-3, ≥3-4, ≥4-5, ≥5-9) 1
Temp_delta Extend of the temperature range in which a strain can grow (calculated from temp_Range trait) °C Quantitative, categorial 5 categories (≥1-5, ≥5-10, ≥10-20, ≥20-30, ≥30) 1
Temp_delta Extend of the temperature range in which a strain can grow (calculated from temp_Range trait) °C Quantitative, categorial 5 categories (≥1-5, ≥5-10, ≥10-20, ≥20-30, ≥30) 1

@hrshdhgd

@hrshdhgd
Copy link
Contributor

hrshdhgd commented Sep 19, 2024

pH_delta prefixes are already in the KG:

pH_opt:mid1 biolink:PhenotypicQuality optimal pH 6 to 7
pH_range:mid2 biolink:PhenotypicQuality pH range 6 to 7
pH_range:mid3 biolink:PhenotypicQuality pH range 7 to 8
pH_delta:low biolink:PhenotypicQuality pH delta 1 to 2
temp_opt:mid1 biolink:PhenotypicQuality optimal temperature 22 deg C to 27 deg C
temp_range:low biolink:PhenotypicQuality temperature range 10 deg C to 22 deg C
NCBITaxon:1121106 biolink:OrganismTaxon Belnapia moabensis DSM 16746
pH_opt:mid2 biolink:PhenotypicQuality optimal pH 7 to 8
pH_delta:mid1 biolink:PhenotypicQuality pH delta 2 to 3

For the other two is there data for them at all? I see just 0 or None values.

All the prefixes in the custom_curies.yaml have been considered during the KG creation.

@realmarcin
Copy link
Contributor Author

realmarcin commented Sep 19, 2024

OK thanks for checking! Yes, if there are no values then nothing to ingest of course!
These are all now in the ontology as well.

Of course I should have checked the merge first!
These are already ingested, so there were some real values available for all three types of delta terms:

grep temp_delta: merged-kg_edges.tsv | wc
3951 27657 538151
grep pH_delta: merged-kg_edges.tsv | wc
2915 20405 391781
grep NaCl_delta: merged-kg_edges.tsv | wc
3123 21861 424900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants