Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promotheus support #3407

Closed
leplatrem opened this issue Apr 22, 2024 · 1 comment · Fixed by #3453
Closed

Add Promotheus support #3407

leplatrem opened this issue Apr 22, 2024 · 1 comment · Fixed by #3453

Comments

@leplatrem
Copy link
Contributor

https://prometheus.io/docs/introduction/overview/

Currently, when installed with [monitoring], Kinto has support for Newrelic and StatsD.

These choices are 7 years old, and may have to be revisited. Namely, we would like to add Prometheus support.

This would probably consist in replacing. app.registry.statsd with something else like an abstraction app.registry.metrics interface.
Since Prometheus requires a new endpoint, and some users may want to stick with StatsD, it could probably be implemented as a built-in plugin.

@Natim
Copy link
Member

Natim commented Apr 22, 2024

Nice!

leplatrem added a commit that referenced this issue Oct 10, 2024
* Move statsd out of core

* Include statsd plugin by default

* Rename config.registry.statsd to config.registry.metrics

* Mock client instead of dynamically loaded function

* Introduce the IMetricsInterface

* Remove unused helper

* Move instrumentation of backends and authentication out of kinto.core.statsd

* Wrap event listeners to delay evaluation of config.registry.metrics after setup

* Skip StatsD test with raw install

* Move tests and assertions where they belong

* Fix coverage to 100%

* Adjust docs and deprecation warnings

* Use single file instead of folder (like flush.py)

* Mention statsd with uWsgi
leplatrem added a commit that referenced this issue Oct 16, 2024
* Introduce the Prometheus lib

* Start plugin

* Unit testing

* Adapt usage of unique parameter to groups

* Skip test when no prometheus installed

* Add test for events

* Enable Prometheus in functional test

* Add section about Prometheus

* Move plugins section above monitoring

* Fix link format in docs

* Remove TODO

* nit docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants