Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to attachments plugin #103

Closed
gabisurita opened this issue Oct 10, 2016 · 5 comments
Closed

Add support to attachments plugin #103

gabisurita opened this issue Oct 10, 2016 · 5 comments
Labels
enhancement stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.

Comments

@gabisurita
Copy link
Member

gabisurita commented Oct 10, 2016

I'm not sure if supporting plugins is in the scope of the Python client, but I think it would be useful to have attachments support.

My idea is to do this through an argument "files" on create, update and patch record methods.

It would also be good to raise an appropriate exception message if the server doesn't support the plugin.

@Natim
Copy link
Member

Natim commented Oct 11, 2016

Yes it would be great. Not that we added the support for kinto-http.js

@leplatrem
Copy link
Contributor

leplatrem commented Oct 14, 2016

Why not!

Maybe we should start by draft some dream code here to see how it would like.

For info, we had some python code here: https://github.com/Kinto/kinto-attachment/blob/master/scripts/upload.py

@leplatrem
Copy link
Contributor

@alexcottner alexcottner added the stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. label Jul 23, 2024
@KevinMind
Copy link

@leplatrem is this something currently on the roadmap? Would you be open to a PR for this feature? It seems like mozilla/addons-server is missing this method in order to use this client for remote settings.

@leplatrem
Copy link
Contributor

@KevinMind a PR would definitely be welcome! Don't hesitate all the questions you need 🙏

leplatrem added a commit that referenced this issue Nov 4, 2024
leplatrem added a commit that referenced this issue Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.
Projects
None yet
Development

No branches or pull requests

5 participants