Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 5 display issues #2047

Open
leplatrem opened this issue Sep 16, 2021 · 3 comments
Open

Bootstrap 5 display issues #2047

leplatrem opened this issue Sep 16, 2021 · 3 comments
Labels
stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. tech-debt

Comments

@leplatrem
Copy link
Contributor

Generic

  • Active tab has gray bottom line
    Screenshot from 2021-09-16 15-09-18

  • Add button icon is black (insconsistent with others (white))
    Screenshot from 2021-09-16 15-10-19

  • Permissions overlap
    Screenshot from 2021-09-16 15-12-02

  • Main app icon is invisible
    Screenshot from 2021-09-16 15-12-56

  • Toolbar icon is cropped
    Screenshot from 2021-09-16 15-13-34

  • Loading table is all gray
    Screenshot from 2021-09-16 15-14-39

Notifications

  • Close button is ugly:
    Screenshot from 2021-09-16 15-08-18

Signoff plugin

Screenshot from 2021-09-16 15-08-36

@alexcottner
Copy link
Contributor

Given that everything we're using is v4, and some of our dependencies don't have bootstrap v5 styling yet, I suggest we punt on trying to upgrade to v5 for now. Any objections?

@alexcottner
Copy link
Contributor

Closing this out for now as it seems high effort and low reward. Somebody re-open if this is a big issue. Will revisit when more dependencies are using v5.

@leplatrem
Copy link
Contributor Author

Makes sense, I'd leave the issue open but remove it from the milestone...

@alexcottner alexcottner reopened this Nov 15, 2023
@alexcottner alexcottner removed this from the OKR H2/2023 milestone Nov 15, 2023
@alexcottner alexcottner added the stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. tech-debt
Projects
None yet
Development

No branches or pull requests

2 participants