Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equlibrate: fix bug with pH charge balancing; mypy #150

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Equlibrate: fix bug with pH charge balancing; mypy #150

merged 2 commits into from
Jul 26, 2024

Conversation

rkingsbury
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.84%. Comparing base (17f90d2) to head (f7d39e9).
Report is 2 commits behind head on main.

Files Patch % Lines
src/pyEQL/engines.py 75.75% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   81.95%   81.84%   -0.12%     
==========================================
  Files           9        9              
  Lines        1480     1482       +2     
  Branches      320      321       +1     
==========================================
  Hits         1213     1213              
- Misses        225      226       +1     
- Partials       42       43       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury added the fix Bug Fixes label Jul 26, 2024
@rkingsbury rkingsbury merged commit a2166cc into main Jul 26, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant