Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvement: add lowest-direct dependency resolution #157

Closed
rkingsbury opened this issue Aug 4, 2024 · 1 comment
Closed

CI improvement: add lowest-direct dependency resolution #157

rkingsbury opened this issue Aug 4, 2024 · 1 comment
Assignees
Labels
github_actions Pull requests that update GitHub Actions code housekeeping

Comments

@rkingsbury
Copy link
Member

We should modify the GitHub CI tests to include lowest-direct dependency resolution, as suggested for another package in
materialsproject/jobflow#640 (comment)

I think this would best be done in the post-merge workflow (called test-comprehensive) rather than the standard testing work flow, but I'm open to suggestions.

@rkingsbury rkingsbury added housekeeping github_actions Pull requests that update GitHub Actions code labels Aug 4, 2024
@abhardwaj73
Copy link
Contributor

Hi Ryan, Looks like the post-merge workflow you mentioned is called post-process.yml.

In the PR I've added the following lines:

        version:
          - { python: "3.9", resolution: highest, extras: strict }
          - { python: "3.10", resolution: lowest-direct, extras: strict }
          - { python: "3.11", resolution: highest, extras: non-strict }
          - { python: "3.12", resolution: lowest-direct, extras: non-strict }

instead of
python-version: ['3.9', '3.10', '3.11']

as done in materialsproject/jobflow#640 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code housekeeping
Projects
None yet
Development

No branches or pull requests

2 participants