Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

screenshotGenerator makes slightly different images when on different hardware #480

Open
stevk opened this issue Jan 2, 2019 · 1 comment
Open

screenshotGenerator makes slightly different images when on different hardware #480

stevk opened this issue Jan 2, 2019 · 1 comment
Labels
bug

Comments

@stevk
Copy link
Contributor

stevk commented Jan 2, 2019

see kcoley/screenshotGenerator#3

Images look the same to the human eye, but git flags them as changed with no code changes.
@bghgary bghgary added the bug label Jan 11, 2019
@bghgary
Copy link
Collaborator

bghgary commented Oct 8, 2019

I was thinking about this. Maybe we can update the screenshot generation scripts to compare the images using a visual comparison with a threshold to avoid this issue entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bghgary @stevk