Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What do we want to test instancing with #419

Open
4 tasks done
stevk opened this issue May 22, 2018 · 4 comments · Fixed by #535
Open
4 tasks done

What do we want to test instancing with #419

stevk opened this issue May 22, 2018 · 4 comments · Fixed by #535
Assignees

Comments

@stevk
Copy link
Contributor

stevk commented May 22, 2018

Below is the list so far.

  • Nodes pointing to the same mesh
  • Nodes pointing to the same skin
  • Primitives pointing to the same material
  • Materials pointing to the same texture
@bghgary
Copy link
Collaborator

bghgary commented May 22, 2018

That's a good start.

Here are some more:

  • Primitive indices/attributes pointing to the same accessors
  • Accessors pointing to the same buffer views
  • Buffer views pointing to the same buffers
  • Textures pointing to the same images

When we do animations, etc.:

  • Animation channels pointing to the same samplers
  • Samplers pointing to the same accessors
  • Morph target attributes pointing to the same accessors
  • Skins pointing to the same skeleton
  • Skins pointing to the same inverseBindMatrices (not sure about this one)

There are probably more.

@stevk
Copy link
Contributor Author

stevk commented Nov 14, 2018

@kcoley could you mark which areas were covered by #462 and close if they've all been addressed.

@stevk
Copy link
Contributor Author

stevk commented Mar 8, 2019

There are models using instancing in several modelgroups, but there should be one modelgroup specifically showcasing instancing, to make these easier to find.

@stevk
Copy link
Contributor Author

stevk commented Jun 26, 2019

Morph is NYI.

@stevk stevk reopened this Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants