Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptor Indexing Tests don't test conditionally accessing descriptors #486

Open
Jasper-Bekkers opened this issue Sep 12, 2024 · 1 comment

Comments

@Jasper-Bekkers
Copy link

Hi,

We're in the wild seeing drivers that don't correctly deal with the following pattern in shaders:

if(handle.isValid()) {
     g_bindlessTable[handle].doStuff();
}

What certain drivers are doing is hoisting the descriptor access to before the isValid check which causes them to potentially access invalid memory (if the descriptor memory isn't backed yet for example).

@Jasper-Bekkers
Copy link
Author

Note: our descriptors are setting the VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT flag properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant