From 24c1b1498ba4f05777f47541968ffe686265c645 Mon Sep 17 00:00:00 2001 From: Graeme Leese Date: Tue, 13 Aug 2024 13:53:40 +0100 Subject: [PATCH] Add extra fast-math decoration in OpPhi tests In the code %comp = OpFOrdGreaterThan %type_bool %arg1 %arg2 the test was applying the correct fast-math decorations to %comp but not to %arg1 or %arg2. This meant that the compiler was still able to infer that the inputs to the comparison could not be certain values and optimise the results accordingly, causing the test to fail. Add the decorations to %arg1 and %arg2 as well. Components: Vulkan Affects: dEQP-VK.spirv_assembly.instruction.*.float_controls2.*.phi_* Change-Id: I814f379599be167a32ee081f65b7d824ed5929de (cherry picked from commit 1e26940a32395ecd12e1927a01a9051f88398538) --- .../vulkan/spirv_assembly/vktSpvAsmFloatControls2Tests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmFloatControls2Tests.cpp b/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmFloatControls2Tests.cpp index 7d8c818e4b..7c57e0920e 100644 --- a/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmFloatControls2Tests.cpp +++ b/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmFloatControls2Tests.cpp @@ -1663,7 +1663,7 @@ void TestCasesBuilder::init() " OpBranch %comp_merge\n" "%comp_merge = OpLabel\n" "%result = OpPhi %type_float %arg2 %true_branch %arg1 %false_branch\n", - B_STATEMENT_USAGE_COMMANDS_TYPE_FLOAT, {"comp", "result"}); + B_STATEMENT_USAGE_COMMANDS_TYPE_FLOAT, {"arg1", "arg2", "comp", "result"}); mo[OID_SELECT] = Op("select", FLOAT_ARITHMETIC, "%always_true = OpFOrdGreaterThan %type_bool %c_float_1 %c_float_0\n" "%result = OpSelect %type_float %always_true %arg1 %arg2\n",