WIP: Encode astc support #952
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkCallow
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Thanks @wasimabbas-arm. Can you now get metrics for ASTC compressed files?
You will need to add tests of the new functionality to the tools CTS and possibly need to update some existing tests.
|
|
||
| ktx_error_code_e ec = KTX_SUCCESS; | ||
| // Decode the encoded texture to observe the compression losses | ||
| ec = ktxTexture2_TranscodeBasis(texture, KTX_TTF_RGBA32, 0); | ||
| if (isFormatAstc((VkFormat)texture->vkFormat)) |
There was a problem hiding this comment.
You can check the colorModel in the DFD to see if it is ASTC rather than the switch statement in isFormatAstc.
| @@ -807,3 +890,232 @@ ktxTexture2_CompressAstc(ktxTexture2* This, ktx_uint32_t quality) { | |||
|
|
|||
| return ktxTexture2_CompressAstcEx(This, ¶ms); | |||
| } | |||
|
|
|||
| struct decompression_workload | |||
There was a problem hiding this comment.
I don't like having the decoder in a file called astc_encode.cpp. I know we talked about this before but I don't recall the answer to "is there a lot of code in this file shared between encode and decode?" If not then I'd prefer the decoder in a separate file. If there is then consider renaming the file to astc_codec.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #810.
Since #810 was adding a separate tool. Its easier to start another cleaner PR.
This PR has:
Commit to add --format option and make it exclusive with --codec
Add ASTC support to encode