Backport 43 fixes #760
Merged
Backport 43 fixes #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was always broken for pipes created by Windows' shells (PowerShell and Command). Became broken in cygwin 3.4.x for pipes created by cygwin/MSYS2/Git for Windows shells when cygwin started mimicing the way Windows shells create pipes. The cause is that setting the `FILE_SYNCHRONOUS_IO_NONALERT` option when creating a pipe causes `cin.seekg(0)` on the pipe to return success when in fact seek is not supported. * Add launchDebugger function and --ld option to invoke it to `ktxApp` class and ktx tool as helpers for debugging pipes on Windows. These are only added when _WIN32 and DEBUG are defined.
They were being done in both `toktx` and the `imageinput` plugin. Fixes #727. * Move image-related utilities and image.hpp from `ktxtools` to `imageio` target for sharing between new and legacy tools. * Change `toktx` to use the updated version of image.hpp. * Make `other_Includes` a system include for `imageio` and `unittests`. * Make `toktx` use `imageio`'s INTERFACE includes instead of directly referencing the directories. * Fix mismatched `new[]` and `delete` in `glloadtests`.
to stop warnings in assimp files. Clang 16.0.5 has a new warning it raises on some of the assimp headers.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 26, 2024
…oup#727 (KhronosGroup#760) * Fix legacy app input from pipes on Windows. From commit 3e7fd0a. Was always broken for pipes created by Windows' shells (PowerShell and Command). Became broken in cygwin 3.4.x for pipes created by cygwin/MSYS2/Git for Windows shells when cygwin started mimicking the way Windows shells create pipes. The cause is that setting the `FILE_SYNCHRONOUS_IO_NONALERT` option when creating a pipe causes `cin.seekg(0)` on the pipe to return success when in fact seek is not supported. Add launchDebugger function and --ld option to invoke it to `ktxApp` class and ktx tool as helpers for debugging pipes on Windows. These are only added when _WIN32 and DEBUG are defined. * Do target_type changes only in toktx. They were being done in both `toktx` and the `imageinput` plugin. Fixes KhronosGroup#727. From commit 2cf053c. Changes included with above fix: - Move image-related utilities and image.hpp from `ktxtools` to `imageio` target for sharing between new and legacy tools. - Change `toktx` and `unittests` to use the updated version of image.hpp. * Changes to make build work with latest compilers in CI services: - Fix mismatched `new[]` and `delete` in `glloadtests`. From commit 3e7fd0a - Warning fixes for clang 14 and cmake 3.26. - Make other_include a SYSTEM include for loadtests (KhronosGroup#762) to stop warnings in assimp files. Clang 16.0.5 has a new warning it raises on some of the assimp headers. From commit 0feeda6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the fixes for input from pipes on Windows and issue #727 to the 4.2 branch.