Add support for fewer components in input files #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkCallow
reviewed
Aug 22, 2023
|
@MarkCallow, FYI, I made some changes that will prevent loading additional unnecessary components. For the purposes of this feature only, there was a straightforward solution. However, long-term, I think we should think about improving the image ops to support a wider set of combinations. Please first merge the CTS changes for issue #752 (KhronosGroup/KTX-Software-CTS#2), then I can remove the draft flag here, and then you can merge this PR, and then the CTS changes for this PR (KhronosGroup/KTX-Software-CTS#3). |
|
@MarkCallow, if you didn't notice, this one is rebased and ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #751.