From e93d43b3c064d641822e4c22e80eb7d3ec6952cc Mon Sep 17 00:00:00 2001
From: Felipe Olmos <luisfelipe.olmosmarchant@orange.com>
Date: Wed, 23 Aug 2023 18:20:45 +0200
Subject: [PATCH] WIP unit-tests

---
 .github/workflows/run-unit-tests.yml | 30 ++++++++++++++++++----------
 packaging/windows/nsis/README.md     |  2 +-
 2 files changed, 20 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml
index 56e3c5dda..bda700021 100644
--- a/.github/workflows/run-unit-tests.yml
+++ b/.github/workflows/run-unit-tests.yml
@@ -27,26 +27,34 @@ jobs:
           targets: norm_test parallel_test parallel_mpi_test learning_test
           override-flags: -DBUILD_JARS=OFF
       - name: Run Unit Tests for the Norm Module
-        if: success() || failure()
-        run: build/${{ matrix.build-setup.cmake-preset }}/bin/norm_test --gtest_output="xml:${{github.workspace}}/reports/report-norm.xml"
+        run: >
+          build/${{ matrix.build-setup.cmake-preset }}/bin/norm_test
+            --gtest_output="xml:reports/report-norm.xml"
       - name: Run Unit Tests for the Parallel Module
         if: success() || failure()
-        run: build/${{ matrix.build-setup.cmake-preset }}/bin/parallel_test --gtest_output="xml:${{github.workspace}}/reports/report-parallel.xml"
+        run: >
+          build/${{ matrix.build-setup.cmake-preset }}/bin/parallel_test
+            --gtest_output="xml:reports/report-parallel.xml"
       - name: Run Unit Tests for the Parallel MPI Module in serial
         if: success() || failure()
-        run: build/${{ matrix.build-setup.cmake-preset }}/bin/parallel_mpi_test --gtest_output="xml:${{github.workspace}}/reports/report-parallel-mpi-serial.xml"
+        run: >
+          build/${{ matrix.build-setup.cmake-preset }}/bin/parallel_mpi_test
+            --gtest_output="xml:reports/report-parallel-mpi-serial.xml"
       - name: Run Unit Tests for the Parallel MPI Module in parallel
         if: success() || failure()
-        run: mpiexec -n 4 build/${{ matrix.build-setup.cmake-preset }}/bin/parallel_mpi_test
-          --gtest_output="xml:${{github.workspace}}/reports/report-parallel-mpi-parallel.xml"
+        run: >
+          mpiexec -n 4 build/${{ matrix.build-setup.cmake-preset }}/bin/parallel_mpi_test
+            --gtest_output="xml:reports/report-parallel-mpi-parallel.xml"
       - name: Run Unit Tests for the Learning Module
         if: success() || failure()
-        run: build/${{ matrix.build-setup.cmake-preset }}/bin/learning_test --gtest_output="xml:${{github.workspace}}/reports/report-learning.xml"
-      - name: Create Unit Test Reports
-        uses: dorny/test-reporter@v1
+        run: >
+          build/${{ matrix.build-setup.cmake-preset }}/bin/learning_test
+            --gtest_output="xml:reports/report-learning.xml"
+      - name: Create Unit Test Reports Dashboards
+        uses: dorny/test-reporter@v1.6.0
         if: success() || failure()
         with:
-          name: Unit Tests
-          path: ${{github.workspace}}/reports/report-*.xml
+          name: Unit Tests Reports (${{ matrix.build-setup.os }})
           reporter: jest-junit
+          path: reports/report-*.xml
           path-replace-backslashes: 'true'  # Necessary for windows paths
diff --git a/packaging/windows/nsis/README.md b/packaging/windows/nsis/README.md
index dab8871d1..71d3663e9 100644
--- a/packaging/windows/nsis/README.md
+++ b/packaging/windows/nsis/README.md
@@ -18,7 +18,7 @@ somewhere in your system. In the example we suppose that they are located at
 # At the root of the repo build the khiops binaries
 cmake --build --parallel --preset windows-msvc-release --target MODL MODL_Coclustering norm_jar khiops_jar
 
-#
+# In the packaging directory build the installer with makensis
 cd packaging/windows/nsis
 makensis `
   /DKHIOPS_VERSION=10.1.1 `