Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Document how users can choose their own shell #27

Open
runlevel5 opened this issue Feb 23, 2021 · 3 comments
Open

Document how users can choose their own shell #27

runlevel5 opened this issue Feb 23, 2021 · 3 comments
Milestone

Comments

@runlevel5
Copy link

No description provided.

@runlevel5 runlevel5 added this to the Beta milestone Feb 23, 2021
@tstromberg
Copy link
Contributor

kernel.cafe has always supported a shell field in users.yaml, but no usage examples exist yet.

Here is the field:
https://github.com/KernelCafe/automation/blob/484ac2b5e2c39701b37372fc526380c4c9046a56/cmd/generate-ansible/main.go#L36

Here is how it gets invoked:

https://github.com/KernelCafe/automation/blob/484ac2b5e2c39701b37372fc526380c4c9046a56/cmd/generate-ansible/main.go#L305

We should probably document this - so I'm going to leave this issue open for the time being.

@tstromberg tstromberg changed the title Allow user to choose their default shell Document how users can choose their own shell Feb 23, 2021
@runlevel5
Copy link
Author

@tstromberg what do you think about falling back to /bin/sh instead of fish?

@tstromberg
Copy link
Contributor

It's sort of off-topic, but as a default, I have a strong preference for guiding users to a friendly modern shell. I'm open to alternatives but have a strong preference for a shell created within the last 20 years. fish seems to be a great fit. It also is slightly incompatible, which is a nice way to break behavioral assumptions

@tstromberg tstromberg modified the milestones: Beta, Launch! Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants