Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Paginator in QueryObject::fetchOne() #118

Open
fprochazka opened this issue Jul 12, 2014 · 11 comments
Open

Use Paginator in QueryObject::fetchOne() #118

fprochazka opened this issue Jul 12, 2014 · 11 comments
Labels
Milestone

Comments

@fprochazka
Copy link
Member

and get rid of setMaxResults(1)

@fprochazka fprochazka added the bug label Jul 12, 2014
@enumag
Copy link
Member

enumag commented Dec 5, 2014

👍 need this :-)

@fprochazka
Copy link
Member Author

@enumag a pullrequest would be nice :)

@enumag
Copy link
Member

enumag commented Dec 5, 2014

@fprochazka I know, I'd love to send it but am currently too busy. :-(

@enumag
Copy link
Member

enumag commented Dec 8, 2014

@fprochazka I wanted to write a failing test at least but it seems there are currently no tests for the QueryObject class.

@jasin755
Copy link
Contributor

jasin755 commented Apr 2, 2015

Please remove setMaxResults(1) in next release :)

@fprochazka
Copy link
Member Author

I think we've learned that this was a bad idea.

@enumag
Copy link
Member

enumag commented Feb 10, 2016

@fprochazka Can you elaborate? I think I missed that lesson. ;-)

@fprochazka
Copy link
Member Author

@enumag if it's not obviouse from #174 (comment) tell me and I'll elaborate

@enumag
Copy link
Member

enumag commented Feb 10, 2016

@fprochazka Well we never actually tried using Paginator for this.

@fprochazka
Copy link
Member Author

@enumag good grief, I should stop closing issues when I'm half asleep :D

And I should start writing longer descriptions if I'm gonna be solving the issue after two years - so I can actually tell what is the issue about.

Using the Paginator from doctrine (note to self) might actually work.

@fprochazka fprochazka reopened this Feb 11, 2016
@fprochazka fprochazka added this to the v4.0 milestone Feb 11, 2016
@enumag
Copy link
Member

enumag commented Feb 11, 2016

@fprochazka :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants