Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on Ruby 3 and remove LC_MESSAGES #900

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ofedoren
Copy link
Contributor

Not so important, but still useful.

@chris1984
Copy link
Member

Hey @ofedoren The tests are failing with ruby WARNING: File locale/bn/LC_MESSAGES/hammer-cli-katello.mo does not exist, generate with 'make all-mo'! No such file or directory @ rb_file_s_mtime - locale/bn/LC_MESSAGES/hammer-cli-katello.mo not found wrong number of arguments (given 2, expected 1)

Are you able to fix that up and we can merge this, I will make sure this gets in before branching.

@ofedoren
Copy link
Contributor Author

ofedoren commented Aug 3, 2023

@chris1984, the fix for that issue is to update rubocop, since it's quite outdated. I've tried to fix all of the offences and I did, but really really lazily, so please re-check after me :)

The only concern of mine is the changes in lib/hammer_cli_katello/content_import.rb. Please, could you ensure I didn't break the functionality (it's not covered by tests)? Essentially, you'd need to re-test #867 PR. These changes are because of https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Security/Open.

UPD: but hey, we're 🍏 on Ruby 3+ here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants