Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GG Cleanup #14

Open
5 tasks
mabby-nyaa opened this issue Aug 4, 2022 · 1 comment
Open
5 tasks

GG Cleanup #14

mabby-nyaa opened this issue Aug 4, 2022 · 1 comment

Comments

@mabby-nyaa
Copy link

mabby-nyaa commented Aug 4, 2022

Light QC. Didn't thoroughly check all signs or dialogue but noticed some egregious differences when comparing with subs I already had. Since these are issues that would potentially span across all TS & dialogue due to widespread adjustments, a more proper review may be needed.

Various breaking changes I noticed with your version of GG (Farfie).

  • TS text living under white block, effectively disappearing.
    link
    Caused by shifting the track lines?

  • TS resampling broke scaling position.
    link
    May be broken in other places as well from across the board resampling pass.

  • Uglier TS from missing / changed fonts.
    link
    This I believe is caused by GG assigning some signs to Default when the default styling was actually a usable font for TS (CAC Moose). Because you changed the default styling for dialogue, a bunch of signs are now much uglier in a handful of episodes. Proper fix would be redoing the TS better, a more simple fix would be changing the line style to a new name and just bring back the old font, and an easy do-nothing fix would be just not changing the dialogue style from original.

  • TS sign colors are darker from color matrix changes.
    link
    TS assigned color values were not corrected when the color matrix was changed from TV.601 to TV.709. Changing the color space does improve a handful of background blended signs (most of the time, some still need adjustments even now), but without correcting all the TS with color values, many signs are now darker or no longer color matched perfectly. Breaking or leaving it worse than before.

  • GG dialogue timing was shifted and now starts some frames before it is spoken. (2 frames earlier in this case)
    link
    Proper fix would be retiming all dialogue (Sushi or modern equivalent / manually?). A more simple fix would be leaving it alone from default. The subs provided below do not have this problem with a simple -1000ms offset for episodes that were trimmed (all but 1?).


I don’t remember where I got this or if I fixed some problems myself, but here are GG (Farfie) subs that don’t have broken TS scaling, missing text, color issues, or timing problems when played in mpv. Subs will need to be retimed ~24 frames on most episodes (-1000ms) since the encode was trimmed. track03 has original dialogue styling, track04 has changed styling and some different TS adjustments in various episodes.

https://www.mediafire.com/file/uyuqb76hqxfpxln/Joshiraku_GG_%28Farfie%29_Subs.zip/file
https://mega.nz/file/lfQQzTCJ#nQlvScvgh5bflsP3WFNcqSIS8pxU3Hp_Mqn4W-6peDM
https://anonfiles.com/27Ebf62by3/Joshiraku_GG_Farfie_Subs_zip

I think I preferred the first track overall. Should probably only use this as a reference to compare TS and see what broke in yours, as there are many adjustments and fixes to GG subs made for the better in this repo and what I would recommend despite the problems. However you could technically revert the resampling, matrix changes, and timing adjustments with minimal issues if you wanted to base the alt track on the original subs with just minor fixes applied on top.

I just think including a cleaned up alt track shouldn’t necessarily mean leaving it more broken in some places than how it came.

LightArrowsEXE added a commit that referenced this issue Aug 11, 2022
LightArrowsEXE added a commit that referenced this issue Aug 11, 2022
LightArrowsEXE added a commit that referenced this issue Aug 11, 2022
@LightArrowsEXE
Copy link
Member

I'll be making per-episode commits. It'd be appreciated if you could double-check them to make sure the fixes are appropriate and I don't miss anything 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants