Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More memory leaks #215

Merged
merged 15 commits into from
Apr 4, 2024
Merged

More memory leaks #215

merged 15 commits into from
Apr 4, 2024

Conversation

JonnyOThan
Copy link
Contributor

No description provided.

@JonnyOThan JonnyOThan marked this pull request as draft March 13, 2024 14:55
@JonnyOThan JonnyOThan marked this pull request as ready for review March 13, 2024 15:08
@JonnyOThan JonnyOThan marked this pull request as draft March 13, 2024 19:57
@JonnyOThan JonnyOThan marked this pull request as ready for review March 14, 2024 22:09
Comment on lines +797 to +798
FlightGlobals.ResetObjectPartUpwardsCache();
FlightGlobals.ResetObjectPartPointerUpwardsCache();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal to reset that cache here since that will often cause it to be immediately rebuilt in every case a debris or another vessel gets out of loading range. Ideally we could be a bit smarter by waiting for next frame and only removing destroyed parts from those caches, but probably not worth the trouble, and I agree this is a potentially quite bad leak.

@gotmachine
Copy link
Contributor

LGTM

@gotmachine gotmachine merged commit 506f886 into dev Apr 4, 2024
1 check passed
@gotmachine gotmachine deleted the more-memory-leaks branch April 5, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants