Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to generate KSP assembly attributes #27

Merged
merged 12 commits into from
Sep 5, 2024

Conversation

drewcassidy
Copy link
Member

@drewcassidy drewcassidy commented Sep 1, 2024

Adds targets enabled by the following properties:

GenerateKSPAssemblyAttribute

If set to true, automatically generates the KSPAssembly for your assembly from the Version property.

GenerateKSPAssemblyDependencyAttributes

If set to true, automatically generates KSPAssemblyDependency attributes for each dependency. Dependencies should have either the CKANIdentifier metadata or KSPAssemblyName metadata. Versions can be supplied with CKANVersion or KSPAssemblyVersion.

Also fixed up the CKAN install stuff so it only runs when absolutely necessary

Up for Bikeshedding:

  • Should any of these be opt-out instead of opt-in?

@drewcassidy drewcassidy marked this pull request as ready for review September 2, 2024 07:07
FileVersion doesnt have the suffix. I could use a custom task and regex but meh
I've changed my mind, MinVer is the way to go.
@drewcassidy drewcassidy changed the title Add functionality to calculate the current version from git tags Add functionality to generate KSP assembly attributes Sep 4, 2024
@drewcassidy
Copy link
Member Author

Changed my mind, MinVer is actually perfect to use and we don't have to reinvent the wheel. Ignore the branch name, im not renaming it

@JonnyOThan JonnyOThan merged commit dd57d2b into KSPModdingLibs:main Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants