Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Localized line breaks missing on Windows #3470

Closed
Normolo opened this issue Oct 31, 2021 · 4 comments · Fixed by #3471
Closed

[Bug] Localized line breaks missing on Windows #3470

Normolo opened this issue Oct 31, 2021 · 4 comments · Fixed by #3471
Labels
GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating Needs more info We need more info Windows Issues specific for Windows

Comments

@Normolo
Copy link

Normolo commented Oct 31, 2021

Background

  • Operating System: Windows 10
  • CKAN Version: v1.30.4
  • KSP Version: 1.12.2

Have you made any manual changes to your GameData folder (i.e., not via CKAN)? No.

Problem

Grammatical Error

Steps to reproduce

  1. Start a removal of a mod
  2. Have the removal of the mod fail

Lack of a space

image

CKAN error code (if applicable):

PLACE CODE HERE !
@Normolo Normolo changed the title [Bug] Briefly summarize your issue here [Bug] Grammatical Error Oct 31, 2021
@HebaruSan
Copy link
Member

HebaruSan commented Oct 31, 2021 •
edited
Loading

Sorry, what grammatical error or lack of a space are you referring to? It's not clear what part of the screenshot is relevant.

@HebaruSan HebaruSan added Needs more info We need more info Support Issues that are support requests labels Oct 31, 2021
@HebaruSan
Copy link
Member

Is it this?

image

We do already have a line break there:

CKAN/GUI/Properties/Resources.resx

Lines 272 to 274 in 41a0143

<data name="MainInstallKnownError" xml:space="preserve"><value>If the above message indicates a download error, please try again. Otherwise, please open an issue for us to investigate.
If you suspect a metadata problem: https://github.com/KSP-CKAN/NetKAN/issues/new/choose
If you suspect a bug in the client: https://github.com/KSP-CKAN/CKAN/issues/new/choose</value></data>

Possibly similar to #2818?

@HebaruSan HebaruSan added GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating Windows Issues specific for Windows and removed Support Issues that are support requests labels Oct 31, 2021
@HebaruSan
Copy link
Member

From some casual reading, it seems that .resx files are supposed to use CRLF line endings, but we have them as normalized to LF in the repo and OS-specific in the working dir (CRLF when checked out on Windows, LF on Linux and Mac), so it would be LF when we build in an Ubuntu container:

CKAN/.gitattributes

Line 31 in 41a0143

*.resx text

@HebaruSan HebaruSan changed the title [Bug] Grammatical Error [Bug] Localized line breaks missing on Windows Oct 31, 2021
@HebaruSan HebaruSan mentioned this issue Oct 31, 2021
Merged
@HebaruSan
Copy link
Member

Hi @Normolo, can you please try this test build and see whether it still has the same problem?

@HebaruSan HebaruSan mentioned this issue Oct 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating Needs more info We need more info Windows Issues specific for Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use CRLF for resx files HebaruSan/CKAN
2 participants
@HebaruSan @Normolo