add more rules for architecture testing

KBTG-Kampus-ClassNest-SE-Java · Mar 20, 2024 · ae66c41 · ae66c41
1 parent 0d32c1e
commit ae66c41
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/kbazaar/src/test/java/com/kampus/kbazaar/architecture/CodingRuleTest.java b/kbazaar/src/test/java/com/kampus/kbazaar/architecture/CodingRuleTest.java
@@ -0,0 +1,17 @@
+package com.kampus.kbazaar.architecture;
+
+import com.tngtech.archunit.core.importer.ImportOption;
+import com.tngtech.archunit.junit.AnalyzeClasses;
+import com.tngtech.archunit.junit.ArchTest;
+import com.tngtech.archunit.lang.ArchRule;
+
+import static com.tngtech.archunit.library.GeneralCodingRules.NO_CLASSES_SHOULD_USE_FIELD_INJECTION;
+
+@AnalyzeClasses(
+        packages = "com.kampus.kbazaar",
+        importOptions = ImportOption.DoNotIncludeTests.class)
+public class CodingRuleTest {
+
+    @ArchTest
+    private final ArchRule no_field_injection = NO_CLASSES_SHOULD_USE_FIELD_INJECTION;
+}
diff --git a/kbazaar/src/test/java/com/kampus/kbazaar/architecture/DependencyRuleTest.java b/kbazaar/src/test/java/com/kampus/kbazaar/architecture/DependencyRuleTest.java
@@ -1,6 +1,7 @@
 package com.kampus.kbazaar.architecture;
 
 import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.classes;
+import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.noClasses;
 
 import com.tngtech.archunit.core.importer.ImportOption;
 import com.tngtech.archunit.junit.AnalyzeClasses;
@@ -36,4 +37,23 @@ public class DependencyRuleTest {
                     .byClassesThat()
                     .areAnnotatedWith(Service.class)
                     .allowEmptyShould(true);
+
+    @ArchTest
+    static final ArchRule repository_should_not_access_services =
+            noClasses()
+                    .that()
+                    .haveSimpleNameEndingWith("Repository")
+                    .should()
+                    .accessClassesThat()
+                    .haveSimpleNameEndingWith("Service");
+
+    @ArchTest
+    static final ArchRule service_should_not_access_controller =
+            noClasses()
+                    .that()
+                    .haveSimpleNameEndingWith("Service")
+                    .should()
+                    .accessClassesThat()
+                    .haveSimpleNameEndingWith("Controller")
+                    .allowEmptyShould(true);
 }