-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
allow @value injection for architecture test
- Loading branch information
1 parent
0515e9e
commit 3855241
Showing
1 changed file
with
26 additions
and
2 deletions.
There are no files selected for viewing
28 changes: 26 additions & 2 deletions
28
kbazaar/src/test/java/com/kampus/kbazaar/architecture/CodingRuleTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,40 @@ | ||
package com.kampus.kbazaar.architecture; | ||
|
||
import static com.tngtech.archunit.library.GeneralCodingRules.NO_CLASSES_SHOULD_USE_FIELD_INJECTION; | ||
import static com.tngtech.archunit.lang.conditions.ArchConditions.beAnnotatedWith; | ||
import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.noFields; | ||
|
||
import com.tngtech.archunit.core.domain.JavaField; | ||
import com.tngtech.archunit.core.importer.ImportOption; | ||
import com.tngtech.archunit.junit.AnalyzeClasses; | ||
import com.tngtech.archunit.junit.ArchTest; | ||
import com.tngtech.archunit.lang.ArchCondition; | ||
import com.tngtech.archunit.lang.ArchRule; | ||
|
||
@AnalyzeClasses( | ||
packages = "com.kampus.kbazaar", | ||
importOptions = ImportOption.DoNotIncludeTests.class) | ||
public class CodingRuleTest { | ||
|
||
@ArchTest private final ArchRule no_field_injection = NO_CLASSES_SHOULD_USE_FIELD_INJECTION; | ||
@ArchTest | ||
private final ArchRule no_field_injection = | ||
noFields() | ||
.should(annotations()) | ||
.as("no classes should use field injection") | ||
.because("assumed we're preferring constructor injection"); | ||
|
||
private static ArchCondition<JavaField> annotations() { | ||
ArchCondition<JavaField> annotatedWithSpringAutowired = | ||
beAnnotatedWith("org.springframework.beans.factory.annotation.Autowired"); | ||
ArchCondition<JavaField> annotatedWithGuiceInject = | ||
beAnnotatedWith("com.google.inject.Inject"); | ||
ArchCondition<JavaField> annotatedWithJakartaInject = | ||
beAnnotatedWith("javax.inject.Inject"); | ||
ArchCondition<JavaField> annotatedWithJakartaResource = | ||
beAnnotatedWith("javax.annotation.Resource"); | ||
return annotatedWithSpringAutowired | ||
.or(annotatedWithGuiceInject) | ||
.or(annotatedWithJakartaInject) | ||
.or(annotatedWithJakartaResource) | ||
.as("be annotated with an injection annotation"); | ||
} | ||
} |