Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Order of Windows Installer Flags #260

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix the Order of Windows Installer Flags #260

merged 1 commit into from
Jun 26, 2024

Conversation

RoyiAvital
Copy link
Contributor

Following the documentation at https://conda.github.io/constructor/cli-options/#windows-installers, the /S flag should appear at the end.

The documentation:

image

Pay attention to:

You can also supply standard NSIS flags, but only after the ones mentioned above:

Following the documentation at https://conda.github.io/constructor/cli-options/#windows-installers, the `/S` flag should appear at the end.
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (b43539a) to head (1a8d715).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files           1        1           
  Lines         204      204           
=======================================
  Hits          183      183           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevengj stevengj merged commit 80c7334 into JuliaPy:master Jun 26, 2024
7 checks passed
@ViralBShah
Copy link
Collaborator

New release: JuliaRegistries/General#109823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants