Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Is this warning really appropriate? #2820

Closed
juliohm opened this issue Jun 27, 2020 · 11 comments
Closed

[FR] Is this warning really appropriate? #2820

juliohm opened this issue Jun 27, 2020 · 11 comments
Labels
enhancement improving existing functionality GR

Comments

@juliohm
Copy link

juliohm commented Jun 27, 2020

Whenever I call a plot recipe twice that uses a colorbar by default, I get this warning:

image

I wonder if this is something that could be fixed? To me it seems like we should be able to plot multiple series on a scene and get the colorbar updated? Is the warning just reflecting a missing implementation?

@mkborregaard
Copy link
Member

It's nice enough with the information, but it could be an @info and less defensively phrased (keeping just the first sentence)

@juliohm
Copy link
Author

juliohm commented Jun 27, 2020

Is it something that is not amenable to fix? The way that series get plotted one after another inhibits the update of the colorbar in the current design, is that it?

@daschw
Copy link
Member

daschw commented Jun 27, 2020

Maybe we could check if the two series share the same color gradient and omit the warning/info in that case.

@juliohm
Copy link
Author

juliohm commented Jun 27, 2020

That seems reasonable and very useful to have.

@juliohm
Copy link
Author

juliohm commented Jun 27, 2020

Another warning that could go away:

image

@daschw daschw added enhancement improving existing functionality GR labels Jun 29, 2020
@isentropic
Copy link
Member

Perhaps these warnings should be handled by Plots, not backends? If we were to cross check the series range and colorbar, it can only be checked in Plots

@juliohm
Copy link
Author

juliohm commented Jun 30, 2020

I think a quick removal of the warnings would already be an improvement. They are not helping much.

@isentropic
Copy link
Member

We cannot just remove the warnings, if this gets unnoticed it might produce wrong plots I think. For now, it could be changed to @info but that is it

@juliohm
Copy link
Author

juliohm commented Jul 8, 2020

These two warnings show up in this tutorial: https://www.youtube.com/watch?v=Ee8K2Dxp-2k

The second warning could be removed without problems in my opinion. People will notice the issue with polar grid labels anyways.

@yha
Copy link
Member

yha commented Aug 9, 2020

Maybe we could check if the two series share the same color gradient and omit the warning/info in that case.

The check does exist in the code, but stopped working because comparison of color gradients was broken in the transition to ColorSchemes. Should be fixed now on PlotUtils master (JuliaPlots/PlotUtils.jl#99).
I still think this should be a warning and not @info, because it means the colorbar is probably wrong. Once comparison of gradients works correctly, I can't think of a scenario where this warning is emitted and the plot is actually correct.

@juliohm
Copy link
Author

juliohm commented Jul 23, 2023

Closing as no longer valid.

@juliohm juliohm closed this as completed Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improving existing functionality GR
Projects
None yet
Development

No branches or pull requests

5 participants