Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for probe-returned key #4

Open
jpsamaroo opened this issue Aug 1, 2023 · 0 comments · May be fixed by #5
Open

Add support for probe-returned key #4

jpsamaroo opened this issue Aug 1, 2023 · 0 comments · May be fixed by #5
Labels
enhancement New feature or request

Comments

@jpsamaroo
Copy link
Member

After discussing what's needed to make ProbeBase work for other probing backends (IntelITT and NVTX in particular), it's clear that we need to support passing a backend-generated key from probe start to probe finish, at least when using a region/span API.

We could probably just assume that all backends will return a UInt64 key from probe start, and accept it as an argument in probe finish just before user arguments are passed. To automate this, I think we should add an @region macro (name up for debate) that will generate the appropriate start/finish calls, and thread through the ID. I'm open to thoughts on what this should look like, especially w.r.t user-provided arguments (e.g. do we want to support passing arguments at probe finish, or at all?).

@simonbyrne @carstenbauer @maleadt

@jpsamaroo jpsamaroo added the enhancement New feature or request label Aug 1, 2023
@jpsamaroo jpsamaroo linked a pull request Aug 26, 2023 that will close this issue
14 tasks
@topolarity topolarity linked a pull request Sep 22, 2023 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant