Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies overwriting methods #116

Closed
pearlzli opened this issue Dec 7, 2020 · 8 comments
Closed

Dependencies overwriting methods #116

pearlzli opened this issue Dec 7, 2020 · 8 comments

Comments

@pearlzli
Copy link

pearlzli commented Dec 7, 2020

When I load DoubleFloats, I get some very long warnings about GenericLinearAlgebra (v0.2.4) overwriting GenericSVD (v0.3.0) and GenericSchur (v0.4.0) methods, similar to those on this Discourse post (also me, from a while ago), this GLA issue, and this GSVD issue. DoubleFloats depends on all three:

DoubleFloats -> {GenericSVD, GenericSchur, Polynomials -> GenericLinearAlgebra}

The GLA issue linked above recommends not using both GLA and GSVD at the same time, since GLA already implements a generic SVD. Would it be possible to have DoubleFloats use only GLA?

@GregPlowman
Copy link
Contributor

Polynomials v1.1.13 (released 4 days ago) introduced dependency on GenericLinearAlgebra
JuliaMath/Polynomials.jl#297

Pinning Polynomials v1.1.12 might be a temp workaround.

@JeffreySarnoff
Copy link
Member

Thank you for the insight. Considering possibilities ...

@davidanthoff
Copy link

I started an attempt to fix this at JuliaLinearAlgebra/GenericLinearAlgebra.jl#71.

@JeffreySarnoff
Copy link
Member

super!

@JeffBezanson
Copy link

Why does this package depend on GenericSVD? Does that mean GenericSVD is just not generic enough?

@JeffreySarnoff
Copy link
Member

At the time, LinearAlgebra was not generic enough and GenericSVD did provide svd and friends that worked with DoubleFloats. So it depends on GenericSVD to provide svd. I know there have been changes in LinearAlgebra .. I will check if that now works generically enough to cover DoubleFloats.

@JeffreySarnoff
Copy link
Member

@JeffBezanson GenericSVD is necessary to provide svd, svdvals etc.
LinearAlgebra, if it provides generic versions, does not provide generic versions that are generic enough.

@JeffreySarnoff
Copy link
Member

maybe all is alright now -- reopen otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants