-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass init to prod in normalization #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
===========================================
+ Coverage 84.13% 94.84% +10.70%
===========================================
Files 2 5 +3
Lines 208 446 +238
===========================================
+ Hits 175 423 +248
+ Misses 33 23 -10 ☔ View full report in Codecov by Sentry. |
ararslan
reviewed
Nov 4, 2022
Co-authored-by: Alex Arslan <[email protected]>
stevengj
reviewed
Nov 5, 2022
stevengj
reviewed
Nov 5, 2022
Gentle bump, is there anything else that needs to be done here? |
Gentle bump |
stevengj
reviewed
May 7, 2023
stevengj
reviewed
Feb 5, 2024
stevengj
reviewed
Feb 5, 2024
stevengj
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalization is defined as
1/prod(dimensions)
, which should be well-defined for an emptydimensions
(in which case the prod evaluates to1
). This PR gets around the following error:and the following runtime dispatch that arises from the error:
After this PR,