Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump codecov/codecov-action from 3 to 4" #128

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Feb 5, 2024

Reverts #127

Coverage was not being uploaded correctly in that PR. A Codecov token needs to be added for coverage reports to be uploaded.

@jishnub jishnub requested a review from giordano February 5, 2024 12:38
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41f58b5) 94.83% compared to head (aa15175) 94.81%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   94.83%   94.81%   -0.02%     
==========================================
  Files           5        4       -1     
  Lines         445      444       -1     
==========================================
- Hits          422      421       -1     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giordano
Copy link
Member

giordano commented Feb 5, 2024

I'm confused by how this works: according to https://github.com/JuliaMath/AbstractFFTs.jl/actions/runs/7784505365/job/21225171516?pr=128#step:8:31 upload failed

@jishnub
Copy link
Contributor Author

jishnub commented Feb 5, 2024

This fails sporadically if there's no Codecov token added to the repo, perhaps due to rate limits. Re-running the job should fix the upload issue.

Some of the other jobs in the run have successfully uploaded their reports.

@devmotion devmotion mentioned this pull request Feb 6, 2024
@devmotion
Copy link
Member

#129 fixes the codecov integration by using a token, I think this might be the better approach than reverting the codecov bump.

@stevengj stevengj closed this in #129 Feb 6, 2024
@devmotion devmotion deleted the revert-127-dependabot/github_actions/codecov/codecov-action-4 branch February 6, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants