Increasing robustness of adjoint plan optimizations #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav-arya
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 93.70% 94.58% +0.87%
==========================================
Files 5 5
Lines 445 443 -2
==========================================
+ Hits 417 419 +2
+ Misses 28 24 -4
☔ View full report in Codecov by Sentry. |
devmotion
reviewed
Oct 21, 2023
devmotion
approved these changes
Oct 21, 2023
|
Bump on merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@devmotion although I was unable to reproduce your concern in #113 (comment), I've tried to make some tweaks to safeguard against any possible type issues in adjoint plans, and also added a test of the promotion behaviour.
Please let me know if you have any remaining concerns -- since this is still blocking release I would also be happy to revert the optimization implemented in #113 if you have concerns about the design that aren't easy to address.