Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move dims arg to keyword? #15

Open
ssfrr opened this issue May 9, 2018 · 2 comments
Open

move dims arg to keyword? #15

ssfrr opened this issue May 9, 2018 · 2 comments

Comments

@ssfrr
Copy link
Contributor

ssfrr commented May 9, 2018

It seems like the convention in Base is (as of recently?) to have dims be a keyword argument. Should AbstractFFT match that convention, rather than as a positional argument?
@ssfrr ssfrr mentioned this issue May 9, 2018
Merged
@carstenbauer
Copy link
Contributor

Was about to open an issue for this. 100% agree.

@carstenbauer carstenbauer mentioned this issue May 11, 2019
Merged
@roflmaostc
Copy link
Contributor

Shall we do that?
Does it break anything? We could still leave the standard second argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carstenbauer @ssfrr @roflmaostc