Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still actively developed? We would like to continue! #4

Closed
kellertuer opened this issue Sep 16, 2024 · 9 comments
Closed

Still actively developed? We would like to continue! #4

kellertuer opened this issue Sep 16, 2024 · 9 comments

Comments

@kellertuer
Copy link
Member

Hi,
very nice package idea you got started here.
We had some ideas about “groups on manifolds” already in Manifolds.jl https://juliamanifolds.github.io/Manifolds.jl/stable/manifolds/group.html for a while – I think we do cover the groups you have covered here,.
We now want to give them move focus by moving them to their own package, see https://github.com/JuliaManifolds/LieGroups.jl for w work-in-progress.

Would you maybe be willing to hand over the package name so we can continue your efforts to provide LieGroups to the Julia community? That would be awesome. We would of course mention that in the about page and you are of course more than welcome to contribute.

It is also not urgent, so please think about this for a while; we would still be super happy if we could use this name LieGroups.jl for our package.

Kind regards,
Ronny
(from the JuliaManifolds GitHub Org)

@kellertuer
Copy link
Member Author

Hi @yuehhua,
I hope you are doing fine. This is just a short check, whether you have seen this already and maybe considered, whether it would be possible to continue this under the JuliaManifolds GitHub organisation umbrella?

@yuehhua
Copy link
Collaborator

yuehhua commented Oct 9, 2024

Thank you for reminder. I missed the first issue and now I checked it. It's my pleasure to hand over the package name and even the package itself to community. If it helps community grow up, I am very willing to see that happens! Would it be good to transfer package to you? Or any other suggestions?

@kellertuer
Copy link
Member Author

kellertuer commented Oct 9, 2024

Woohow! Super great!

I already discussed that a bit on slack with people from the general registry.
My proposal is the following

  • we add an entry to our News.md where the name is from and where the previous versions are from
  • We would take over the UUID, then the next version 0.1.0 would just be a breaking change
  • You would be added to our Project.toml as an author
  • You are of course super welcome as a developer, we can of course add you

If you have any other ideas we should take into account when transferring, let us know.

I discussed a bit with Michael @goerz and he proposed to even fork this repository do a delete-commit and rebase our project.
While I do see that this would make the connection even more visible (ours would forever be marked as a fork of this),
I feel that would be a bit complicated to do – what do you think about the approach? Do you feel fork/rebase is necessary? If so, we would of course try to do that as well.
A large disadvantage of the fork/rebase approach would be, that the issues we started and opened and PRs we did would be lost on the current repository on GitHub.

@kellertuer
Copy link
Member Author

Hi again,
we discussed a bit with people from the General Registry and internally in @JuliaManifolds.

An idea is to keep the current history here. The best to do that is, to move this repository to our organisation, then add our new modelling to this repository.
That way it is really a breaking/rewrite release we do and it continues your history even.

If you add us (me and/or @mateuszbaran) here as admins, we can do that carefully. All other proposed mentions we would of course also do.

@yuehhua
Copy link
Collaborator

yuehhua commented Oct 9, 2024

Sure! Feel free to add your model into the package. Maybe I just transfer this repo to you and you could move it into @JuliaManifolds. This could also keep the history in the repo and go on following development.

@kellertuer
Copy link
Member Author

Oh, that was fast ;) I can check, I would maybe be easier to directly move it to JuliaManifolds, but sure, I can first move it to me, since before moving to JuliaManifolds we would also have to rename the ongoing WIP one linked above.

@kellertuer
Copy link
Member Author

So we hopefully finished the rework.

@kellertuer
Copy link
Member Author

@yuehhua thanks this was now super fast! I think we finished all things mentioned above. We will add a remark in the docs (probably the about page) as well for sure. If you feel there is a “transition manual” from your code to ours necessary as well, we can also do that; we do one to transition from Manifolds.jl anyways.

If otherwise everything is clarified here, we can also close this issue.

@yuehhua
Copy link
Collaborator

yuehhua commented Oct 9, 2024

A "transition manual" sounds great! I am glad to hand over this package to whom really care about. Thank you so much!

@yuehhua yuehhua closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants