Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kfold time series #58

Open
luboshanus opened this issue Feb 21, 2022 · 3 comments
Open

kfold time series #58

luboshanus opened this issue Feb 21, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@luboshanus
Copy link

Hi,

have you thought about porting some Time Series utility functions? Such as kfold for time series?

https://alan-turing-institute.github.io/MLJ.jl/stable/evaluating_model_performance/#MLJBase.TimeSeriesCV

julia> MLJBase.train_test_pairs(TimeSeriesCV(nfolds=3), 1:10)
3-element Vector{Tuple{UnitRange{Int64}, UnitRange{Int64}}}:
 (1:4, 5:6)
 (1:6, 7:8)
 (1:8, 9:10)

Thanks.

@juliohm
Copy link
Member

juliohm commented Feb 21, 2022

I am not the maintainer of MLUtils.jl but I believe that anything related to specific domains such as time series, spatial data should be developed in separate projects.

For example, in geospatial ML there are a couple of methods available in GeoStats.jl: https://juliaearth.github.io/GeoStats.jl/stable/validation.html

You could even use these with time series data. Alternatively, you can propose specific validation methods in TimeSeries.jl or any other package that is devoted to the analysis of time series objects.

@darsnack
Copy link
Member

MLDataPattern.jl had time series functions, but they were tricky to work with and didn't compose as well with the rest of the package. In general, time dimensions are hard to get right. So, a quick port of the MLDataPattern.jl functions is probably not what we want here. Indeed, what we finally land on might be more appropriate in a separate package as Julio suggested.

So, the answer is yes, but whatever is proposed will have to be carefully considered for how we want to work with temporal data in general.

@darsnack darsnack added the enhancement New feature or request label Feb 22, 2022
@luboshanus
Copy link
Author

What about a simple kfolds like this: https://stats.stackexchange.com/a/14109
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants