Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix some direct solve ambiguities #181

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

termi-official
Copy link

Hotfix as proposed in JuliaArrays/BlockArrays.jl#319

@termi-official termi-official marked this pull request as draft November 10, 2023 15:23
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d44e944) 87.47% compared to head (300ceaf) 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #181       +/-   ##
==========================================
- Coverage   87.47%   0.00%   -87.48%     
==========================================
  Files          11      11               
  Lines        1812    1712      -100     
==========================================
- Hits         1585       0     -1585     
- Misses        227    1712     +1485     
Files Coverage Δ
src/ldiv.jl 0.00% <0.00%> (-90.56%) ⬇️
ext/ArrayLayoutsSparseArraysExt.jl 0.00% <0.00%> (-100.00%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@termi-official termi-official changed the title Hotfix WR form ambiguity. Hotfix some direct solve ambiguities Nov 10, 2023
@termi-official termi-official marked this pull request as ready for review November 10, 2023 18:04
@termi-official
Copy link
Author

I am still lost why only the WY form has issues, but this PR should fix it. Plus it fixes ambiguities with some sparse direct solve dispatches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant