From 6a27b6811a568ddb56c2e1c8808d8ff3640b5fb5 Mon Sep 17 00:00:00 2001
From: Cody Tapscott <84105208+topolarity@users.noreply.github.com>
Date: Tue, 9 Jul 2024 16:01:30 +0200
Subject: [PATCH] trace-compile: don't generate `precompile` statements for
 OpaqueClosure methods (#55072)

These Methods cannot be looked up via their type signature, so they are
incompatible with the `precompile(...)` mechanism.
---
 src/gf.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/gf.c b/src/gf.c
index 29501883dc041..9f92647244c67 100644
--- a/src/gf.c
+++ b/src/gf.c
@@ -2393,6 +2393,8 @@ static void record_precompile_statement(jl_method_instance_t *mi)
         return;
     if (!jl_is_method(def))
         return;
+    if (def->is_for_opaque_closure)
+        return; // OpaqueClosure methods cannot be looked up by their types, so are incompatible with `precompile(...)`
 
     JL_LOCK(&precomp_statement_out_lock);
     if (s_precompile == NULL) {
@@ -2569,7 +2571,7 @@ jl_code_instance_t *jl_compile_method_internal(jl_method_instance_t *mi, size_t
         jl_atomic_store_release(&codeinst->invoke, ucache_invoke);
         jl_mi_cache_insert(mi, codeinst);
     }
-    else if (did_compile) {
+    else if (did_compile && codeinst->owner == jl_nothing) {
         record_precompile_statement(mi);
     }
     jl_atomic_store_relaxed(&codeinst->precompile, 1);