From 1ba035da42110313b84e8edf2dccd3aa9a2a5082 Mon Sep 17 00:00:00 2001 From: Cody Tapscott <84105208+topolarity@users.noreply.github.com> Date: Mon, 21 Oct 2024 15:16:53 -0400 Subject: [PATCH] trimming: don't abort where we used to resolve dynamic calls (#56271) This call resolution code was deleted in #56179 (rightfully so), but it should be a no-op until we implement this in inference. --- src/codegen.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/codegen.cpp b/src/codegen.cpp index eaa3cc8176ad5..b0d5038024900 100644 --- a/src/codegen.cpp +++ b/src/codegen.cpp @@ -5806,7 +5806,8 @@ static jl_cgval_t emit_call(jl_codectx_t &ctx, jl_expr_t *ex, jl_value_t *rt, bo } int failed_dispatch = !argv[0].constant; if (ctx.params->trim != JL_TRIM_NO) { - abort(); // this code path is unsound, unsafe, and probably bad + // TODO: Implement the last-minute call resolution that used to be here + // in inference instead. } if (failed_dispatch && trim_may_error(ctx.params->trim)) {