Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated bindings RGB4 RGB1 #557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dgleich
Copy link

@dgleich dgleich commented Oct 20, 2024

This removes the deprecated bindings for RGB4 and RGB1, see discussion:

JuliaIO/ImageMagick.jl#235
and similar fix in ColorTypes.jl
JuliaGraphics/ColorTypes.jl#312

It also requires the new version of ColorTypes in Compat, but that will cause failures until that version is registered.

CC: @ViralBShah, @ararslan

@ViralBShah
Copy link

ColorTypes.jl registration PR: JuliaRegistries/General#117694

Let's re-run the CI in an hour or so.

@ViralBShah
Copy link

There is an ambiguity test failing:

     Testing Running tests...
Test Failed at /home/runner/work/Colors.jl/Colors.jl/test/runtests.jl:2
  Expression: isempty(detect_ambiguities(Colors))
   Evaluated: isempty(Tuple{Method, Method}[(_convert(::Type{Cout}, ::Type{C1}, ::Type{C1}, c) where {Cout<:Color, C1<:Color} @ ColorTypes ~/.julia/packages/ColorTypes/0RO5O/src/conversions.jl:90, _convert(::Type{Cdest}, ::Type{Odest}, ::Type{Osrc}, g) where {Cdest<:Color, Odest, Osrc<:AbstractGray} @ Colors ~/work/Colors.jl/Colors.jl/src/conversions.jl:75)])

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.48%. Comparing base (f0a508b) to head (12253dc).
Report is 9 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f0a508b) and HEAD (12253dc). Click for more details.

HEAD has 34 uploads less than BASE
Flag BASE (f0a508b) HEAD (12253dc)
37 3
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #557       +/-   ##
===========================================
- Coverage   98.82%   87.48%   -11.35%     
===========================================
  Files          10        9        -1     
  Lines        1281      831      -450     
===========================================
- Hits         1266      727      -539     
- Misses         15      104       +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link

Commenting out the ambiguity test, everything else runs fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants