Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing AbstractRNG to rand #284

Open
theogf opened this issue Aug 13, 2022 · 3 comments
Open

Passing AbstractRNG to rand #284

theogf opened this issue Aug 13, 2022 · 3 comments

Comments

@theogf
Copy link

theogf commented Aug 13, 2022

Right now it's not possible to pass a random number generator to rand(::Type{Colorant}).
Would you be open to a PR fixing this reproducibility issue by adding rand(::AbstractRNG, ::Type{Colorant}) and co?

@theogf
Copy link
Author

theogf commented Nov 25, 2022

@johnnychen94 I think this is already fixed in the dev version of 0.12, would it be possible to get a release?

@johnnychen94
Copy link
Member

v0.12 seems not finished according to @kimikage's plan, it would be great to have some new love to finish it

I get too busy these days to contribute; really sorry about that.

@kimikage
Copy link
Collaborator

It could be backported to v0.11.
cf. #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants