-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat) #377
CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat) #377
Conversation
… existing compat)
62a3bb5
to
2c2bcd8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 12 12
Lines 394 394
=======================================
Hits 382 382
Misses 12 12 ☔ View full report in Codecov by Sentry. |
I'm not so familiar with Documenter.jl. @devmotion I think you have more experience. Is it fine to put |
I think ideally we should reduce the size of the webpages, e.g., by outputting png images instead of large svgs. For instance, apparently the size of the HTML file for the mauna loa example is more than 6 MB 😱 That being said, to move on with this PR I think the next-best option is to open an issue that lists these examples and allows us to fix these in follow-up PRs, and set |
Ok I'll do it this way then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @devmotion . Please feel free to merge when formatting is sorted -- no need for a patch bump since files in src
aren't changed.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This pull request changes the compat entry for the
Documenter
package from0.27
to0.27, 1
for package docs.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.