CompatHelper: bump compat for Documenter to 1 for package test, (keep existing compat) #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… existing compat)
theogf
force-pushed
the
compathelper/new_version/2023-09-16-01-04-04-056-02228823460
branch
from
d0a6537
to
2bfac95
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 12 12
Lines 394 394
=======================================
Hits 382 382
Misses 12 12 ☔ View full report in Codecov by Sentry. |
…04-056-02228823460
…04-056-02228823460
|
@devmotion should we drop the old compats here as well? Otherwise LGTM. |
…04-056-02228823460
|
Yes, I don't think there's a strong reason to keep them. |
simsurace
reviewed
Nov 20, 2023
simsurace
deleted the
compathelper/new_version/2023-09-16-01-04-04-056-02228823460
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Documenterpackage from0.24, 0.25, 0.26, 0.27to0.24, 0.25, 0.26, 0.27, 1for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.