Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Adapt compat #25

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

jeremiedb
Copy link
Contributor

Add compat entry for Adapt v4. Notably needed by Flux: FluxML/Flux.jl#2362

@christiangnrd
Copy link

Seems like this forces Referenceables.jl down to 0.1.0 (before it supported Adapt) which is causing the errors. Odds of it getting compat support merged seem like basically zero, but since Referenceables support is from an extension, and this PR keeps support for lower versions of Adapt that won't cause those errors, I think this is fine to merge.

@jeremiedb
Copy link
Contributor Author

@MasonProtter Is it reasonable to add https://github.com/tkf/Referenceables.jl to the JuliaFolds2 org?
It looks like a fairly lightweight package and having it into JuliaFolds2 would allow to bump the Adapt compat.
Otherwise, could dropping the Referenceables.jl be considered?

@MasonProtter
Copy link
Member

Hey sorry for the late reply, yeah that should be doable

@MasonProtter
Copy link
Member

Okay so https://github.com/JuliaFolds2/Referenceables.jl now exists and I've opened a PR for it to be the new source for the general registry: JuliaRegistries/General#98495

Once that goes through I can tag a new version with Adapt v4 compat (tests already pass with Adapt v4)

@jeremiedb
Copy link
Contributor Author

Thanks for the quick turnaround! Regarding the change of org for Referenceables (https://github.com/JuliaRegistries/General/pull/98495/files), should it include the .git at the end of the repo?
repo = "https://github.com/JuliaFolds2/Referenceables.jl.git"

@MasonProtter
Copy link
Member

Oops, good catch. Fixed now.

@MasonProtter
Copy link
Member

Looks like some stuff needs to be fixed for nightly, but that can be done in a separate PR.

@MasonProtter MasonProtter merged commit da3ea49 into JuliaFolds2:master Jan 9, 2024
6 of 8 checks passed
@MasonProtter
Copy link
Member

@jeremiedb this change should be available from the general registry once this PR merges: JuliaRegistries/General#98526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants