Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate whether we can specialize less #190

Open
simeonschaub opened this issue Aug 13, 2021 · 1 comment
Open

investigate whether we can specialize less #190

simeonschaub opened this issue Aug 13, 2021 · 1 comment

Comments

@simeonschaub
Copy link
Member

We will likely have to be more careful than in JuliaDiff/ChainRulesTestUtils.jl#205 and JuliaDiff/ChainRules.jl#499, since there are some hot paths here we probably do want to specialize, but I suspect that there are still some gains to be had. https://timholy.github.io/SnoopCompile.jl/stable/pgdsgui/ might be helpful here.
@oxinabox
Copy link
Member

Yeah, this code has some very hot paths, since we need to evaluate the primal function many times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oxinabox @simeonschaub