Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muladd test code doesn't test complex numbers. #753

Closed
oxinabox opened this issue Nov 10, 2023 · 2 comments
Closed

muladd test code doesn't test complex numbers. #753

oxinabox opened this issue Nov 10, 2023 · 2 comments
Labels
good first issue Good for newcomers testing Related to tests

Comments

@oxinabox
Copy link
Member

The muladd code looks like it tests with complex number but actually never generates complex number, just generating floats again a second time

@testset "muladd(x::$T, y::$T, z::$T)" for T in (Float64, ComplexF64)
test_frule(muladd, 10randn(), randn(), randn())
test_rrule(muladd, 10randn(), randn(), randn())
end

This PR should be small and not at all difficult.

@oxinabox oxinabox added good first issue Good for newcomers testing Related to tests labels Nov 10, 2023
@not-physicist
Copy link
Contributor

#786 should fix this.

@mcabbott
Copy link
Member

Indeed. (If you say #753 in the first message of a PR, github will automatically close the issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers testing Related to tests
Projects
None yet
Development

No branches or pull requests

3 participants