Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CategoricalAxis() not exported #288

Closed
dpabon opened this issue Jul 7, 2023 · 5 comments
Closed

CategoricalAxis() not exported #288

dpabon opened this issue Jul 7, 2023 · 5 comments

Comments

@dpabon
Copy link
Contributor

dpabon commented Jul 7, 2023

In v0.5

CategoricalAxis() is not defined (maybe not exported?)

@felixcremer
Copy link
Member

This is part of the change to DimensionalData.jl. We don't have our own Axis types like RangeAxis and CategoricalAxis anymore. Everything is now a DimensionalData.Dim and you should replace your previous CategoricalAxis("AxisName", ["Val1", "Val2"]) by the Dimension Dim{:AxisName}(["Val1", "Val2"]).

@dpabon
Copy link
Contributor Author

dpabon commented Jul 11, 2023

Hi Felix,

Thanks for the clarification. As this version YAXArrays break previous code. I will suggest mentioning it in the release notes. Maybe also to include which functions are not exported anymore and the equivalent.

@felixcremer
Copy link
Member

Yes, that is a good idea. Would you like to start a PR for that?

@dpabon
Copy link
Contributor Author

dpabon commented Jul 11, 2023

I don't have time this week, but I can do it after my holidays in mid-August.

@dpabon
Copy link
Contributor Author

dpabon commented Aug 16, 2023

I saw this is now included in the documentation, then I will close this issue.

@dpabon dpabon closed this as completed Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants