From 9c9e2a385e557dad7fd2ff8497eebfbeafe83c86 Mon Sep 17 00:00:00 2001
From: Felix Cremer <fcremer@bgc-jena.mpg.de>
Date: Mon, 21 Oct 2024 10:22:32 +0200
Subject: [PATCH] Remove the on_error keyword for parallel execution (#452)

This makes sure, that the errors are actually thrown and not hidden.
---
 src/DAT/DAT.jl      |  2 +-
 test/DAT/mapcube.jl | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/DAT/DAT.jl b/src/DAT/DAT.jl
index 706324fa..0e9f6917 100644
--- a/src/DAT/DAT.jl
+++ b/src/DAT/DAT.jl
@@ -708,7 +708,7 @@ function runLoop(dc::DATConfig, showprog)
             "YAXArrays is not loaded on all workers. Please run `@everywhere using YAXArrays` to fix.",
         )
         mapfun = showprog ? progress_pmap : pmap
-        mapfun(CachingPool(workers()),allRanges, on_error=identity) do r
+        m = mapfun(CachingPool(workers()),allRanges) do r
             incaches, outcaches, args = getallargs(dc)
             updateinars(dc, r, incaches)
             if dc.ntr[myid()] > 1
diff --git a/test/DAT/mapcube.jl b/test/DAT/mapcube.jl
index 2252610a..3ce47135 100644
--- a/test/DAT/mapcube.jl
+++ b/test/DAT/mapcube.jl
@@ -60,4 +60,14 @@
         r = mapCube(simple_fun, (a1, a2), indims=(indims, indims), outdims=outdims, max_cache = "0.1GB")
         @test r.data == a1.data .+ permutedims(a2.data,(1,3,2))
     end
+
+    @testset "Error shown in parallel" begin
+        x,y,z = X(1:4), Y(1:5), Z(1:6)
+        a1 = YAXArray((x,y,z), rand(4,5,6))
+        indims = InDims("x")
+        outdims = OutDims("x")
+        @test_throws Exception mapCube((xout, xin) -> xout .= foo(xin), a1; indims, outdims, ispar=false)
+        @test_throws CapturedException mapCube((xout, xin) -> xout .= foo(xin), a1; indims, outdims, ispar=true)
+        
+    end
 end
\ No newline at end of file