fix tests on nightly and 32-bit #3463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkamins
commented
Sep 7, 2024
| @@ -760,7 +760,7 @@ end | |||
| df = DataFrame( | |||
| A=Int64[1,4,9,16,25,36,49,64], | |||
| B = [ | |||
| md"[DataFrames.jl](http://juliadata.github.io/DataFrames.jl)", | |||
| md"ABC", | |||
There was a problem hiding this comment.
handling of links in MD changed in nightly. But since it is unable I propose just not to test it.
|
Failing CI is unrelated. I want to merge this and next consider if anything needs to be added and make a DataFrames.jl 1.7 release as we have not had a release for a year. |
nalimilan
approved these changes
Sep 7, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It in particular fixes an error that enabled multithreading in cases where it should be disabled