Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass multiple predicates in Cols and mix them with other selectors #3279

Merged
merged 3 commits into from
Feb 5, 2023
Merged

Allow to pass multiple predicates in Cols and mix them with other selectors #3279

merged 3 commits into from
Feb 5, 2023

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Feb 2, 2023 •
edited
Loading

Fixes issue raised on Slack.

I do not remember why we have not added support for it from the start, but I do not see the reason to disallow selectors like:

df[:, Cols(startswith("a"), endswith("2"))]

@bkamins bkamins added this to the 1.5 milestone Feb 2, 2023
@bkamins bkamins added the feature label Feb 2, 2023
@bkamins
Copy link
Member Author

bkamins commented Feb 2, 2023

Potentially related is #3034 (but I do not think we are going to implement it).

@bkamins bkamins merged commit 3368d85 into main Feb 5, 2023
@bkamins bkamins deleted the bk/flexible_cols branch February 5, 2023 07:34
@bkamins
Copy link
Member Author

bkamins commented Feb 5, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@bkamins @nalimilan