Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MATLAB's "zplane" like plot of a Filter #382

Open
pineapplehunter opened this issue Oct 31, 2020 · 2 comments
Open

MATLAB's "zplane" like plot of a Filter #382

pineapplehunter opened this issue Oct 31, 2020 · 2 comments

Comments

@pineapplehunter
Copy link

Hi.
I am taking a course in university aboud DSP and I wanted a plot of a filter that looks like the "zplane" plot in MATLAB.
I could not find a way to plot the filters in this repo so I made my own code for it. It's in this gist.
https://gist.github.com/pineapplehunter/bf75b8d67a1d6859dfabd8dc7d987c31

The output plot looks like this.
testout

I don't know if this repo is the right place to put this code, but if it is I'd like to make a PR. If a PR sounds good where should this code be in the source tree?

@martinholters
Copy link
Member

Ref. #203 and #226. FWIW, I'd also consider a dependency on RecipesBase acceptable.

Another issue is that we should probably support a better API for accessing the poles and zeros than via the internal fields of ZeroPoleGain.

@tapyu
Copy link

tapyu commented Jul 20, 2022

Is this support already implemented? This pzplane matlab-like worked like a charm. It definitely should be added to the DSP.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants