Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement on Bode plot phase #312

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Improvement on Bode plot phase #312

wants to merge 9 commits into from

Commits on Sep 2, 2020

  1. Fix bode plot always negative phase 

    If the phase was initially less than -180 degrees, the bode plot would plot with positive initial phase
    @tallakt
    tallakt committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    b799c51 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Algorithm to estimate initial phase angle for bode 

    We use the zero poles (continuous) and poles on the unit circle (discrete) to estimate the phase angle at the left side of the bode plot. Angle unwrap starts from this angle, then the initial angle is not used anymore.
    @tallakt
    tallakt committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    55eca81 View commit details
    Browse the repository at this point in the history

  2. Allow unwrap! to start from an initial value

    @tallakt
    tallakt committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    feecfbc View commit details
    Browse the repository at this point in the history

  3. Optimize bode function

    @tallakt
    tallakt committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    066bce8 View commit details
    Browse the repository at this point in the history

  4. Fix a bug in unwrap! 

    Sometimes the use of - would not work because the operands would be a scalar and an array
    @tallakt
    tallakt committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    3281062 View commit details
    Browse the repository at this point in the history

  5. Optimize bode function by using function count

    @tallakt
    tallakt committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    579acf4 View commit details
    Browse the repository at this point in the history

  6. Add init=... for bodeplot phase with unwrap

    Tallak Tveide committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    22a369d View commit details
    Browse the repository at this point in the history

  7. Make bode phase estimate thresholds configurable

    Tallak Tveide committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    d9075a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Bode plot frequency disabled for DelayLtiSystem 

    The heuristic used to find the initial phase at w=0 for bode plots does not work for systems of type DelayLtiSystem. So it will default to zero initial phase (which is wrong for many systems, but at least it doesn't blow up).
    Tallak Tveide committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    dab68bc View commit details
    Browse the repository at this point in the history