Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple systems in same plot has inconsistent display #640

Open
albheim opened this issue Feb 18, 2022 · 4 comments
Open

Multiple systems in same plot has inconsistent display #640

albheim opened this issue Feb 18, 2022 · 4 comments

Comments

@albheim
Copy link
Member

albheim commented Feb 18, 2022

Have two systems H and H2 to compare. Running

bodeplot([H, H2])

I get a nice plot with legend G1 and G2 so I know which is which. Running

plot(step.([H, H2]))

does not give any. Easy to add in the call, but just felt if there are automatic labels for one one there might as well be for the other to be consistent.

@baggepinnen
Copy link
Member

I'm opposed to automatic labels, because they behave very poorly if you call bodeplot twice. Also, if you plot and set a title, next call to bodeplot will override your title which is quite terrible.

@baggepinnen
Copy link
Member

The same applies to our custom ticks in bode. Plot twice where the axes differ between the plots and the ticks will be messed up.

@albheim
Copy link
Member Author

albheim commented Feb 18, 2022

I'm mostly arguing for consistency, so I'd be equally up for not having it anywhere (or maybe more now that I think about the problems it might cause).

@baggepinnen
Copy link
Member

I also favor consistency. Every time we've tried to be smart in the plot recipes it has backfired and been prone to breakage with time, so I'd really like to get rid of most of the smartness, like custom ticks, labels and latex stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants